Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable modeling of floating MHK turbines #1477

Merged
merged 39 commits into from
Apr 24, 2023

Conversation

hkross
Copy link
Contributor

@hkross hkross commented Mar 3, 2023

This pull request is ready to be merged.

Development is complete, documentation has been updated, and all regression tests pass. A new floating MHK regression test has been added. A corresponding r-test branch is on the OpenFAST/r-test repository.

Feature or improvement description

This pull request allows floating MHK turbines to be modeled by allowing the tower, hub, nacelle, and rotor to be defined below the platform and below the MSL. For fixed and floating MHK turbines, the coordinate systems remain unchanged from those used for wind turbines. However, the geometry for fixed MHK turbines is defined relative to the seabed and for floating MHK turbines is defined relative to the MSL. InflowWind values are defined relative to the seabed for both fixed and floating MHK turbines.

Impacted areas of the software

  • AeroDyn module
  • AeroDyn driver
  • ElastoDyn module
  • OpenFAST glue code

Test results

All regression tests have been updated and pass. A new floating MHK regression test has been added.

Check list

  • Add new floating MHK regression test and baselines

hkross added 27 commits July 8, 2022 13:12
@hkross hkross changed the title Feature/floating mhk Enable modeling of floating MHK turbines Mar 3, 2023
@andrew-platt andrew-platt marked this pull request as draft March 8, 2023 22:29
@andrew-platt andrew-platt self-assigned this Mar 8, 2023
@hkross hkross marked this pull request as ready for review April 21, 2023 22:16
@andrew-platt
Copy link
Collaborator

I know you have done extensive testing with on this feature, particularly with flipping the tower in ED. Could you include a couple of plots of the testing here for future reference?

@andrew-platt andrew-platt added this to the v3.5.0 milestone Apr 21, 2023
@andrew-platt
Copy link
Collaborator

There was a conflict after merging #1543. I resolved this with two commits.

Copy link
Contributor

@ebranlard ebranlard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this pull request, it tracks the change of tower heights and water level throughout the modules.

I have few random comments that are mostly personnal preferences and open to discussion, so they might be safe to discard :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in favor of binary files added to the repo..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to the AeroDyn documentation here (https://openfast.readthedocs.io/en/main/source/user/aerodyn/index.html), along with several other reference documents. I did not add it originally but noticed that it was not the most recent version, so just replaced it with the current version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree, but until all of these Word documents get ported over to readthedocs, I'd prefer the Word docs get shared. Having Word documentation is better than no documentation!

@hkross
Copy link
Contributor Author

hkross commented Apr 24, 2023

To check the accuracy of changes made to OpenFAST to allow floating MHK turbines to be modeled with the tower and RNA below the platform, simulations were run with land-based wind turbine example cases. Comparisons were made between the original definitions of these turbines and definitions in which all components were below ground (i.e., assigned negative Z coordinates). To ensure both definitions were equivalent, a steady and uniform inflow was used, shaft tilt was set to zero, tower shadow effects were neglected, and gravity was negative for the "upside down" case. Several outputs for the 5MW_Land_BD_DLL_WTurb r-test run this way are plotted here. Note that the upside down case of TwrBsFyt is plotted as negative to show agreement. It is expected that this output will be equal and opposite.

TwrTpTDxi
TipTDxr
TwrBsFyt

@hkross
Copy link
Contributor Author

hkross commented Apr 24, 2023

@andrew-platt I have addressed all comments, and it should be good to go. I am not sure why one of the FF tests is now failing.

@andrew-platt andrew-platt merged commit d125157 into OpenFAST:dev Apr 24, 2023
@hkross hkross deleted the feature/FloatingMHK branch April 24, 2023 23:17
@andrew-platt andrew-platt mentioned this pull request May 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants