-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did for current shaper not working under certain circumstances #784
Conversation
This was there to prevent negative calculation when live_pwr > max_pwr. As in this case, evse should stop anyway. I'm pretty sure the 73 issue is not caused by this. |
I test the build openevse_wifi_v1 on my EVSE with 8.2.3.T2 firmware. Every thing work well the current regulation work again to target max_pwr (set to 8400W), I also test a change in max_pwr value during the charge (around 20h in the figure below) and the regulation follow the new max_pwr value without problem. |
Removing that check has allowed my install to load balance as expected. On the latest release build (5.0.2), The EVSE could sit at full speed and still be a few kW over the set limit. The negative Value in the max_pwr - live_pwr is key to the operation of the load balancing max_pwr = 8000, live_pwr = 10000, voltage = 230, getAmps() = 32 _max_cur = ((max_pwr - livepwr) / evse.getVoltage()) + evse.getAmps(); _max_cur = ((8000 - 10000) / 230) + 32 Possibly a check on _max_cur to prevent that from going negative, If the reduction was more than 32 amps _max_cur would go negative. (or rollover?) |
Thanks for the test. The saturation prevention was there just in case negative value could mess-up something. Seeing it works ok, there''s no need to keep it. |
In an abundance of caution, |
fix #762