Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post total wh to Emoncms instead of watt-seconds #195

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

glynhudson
Copy link
Contributor

@glynhudson glynhudson commented Nov 1, 2018

Currently the OpenEVSE posts watt-seconds to Emoncms. IMO this is particular unuseful and probably my mistake!

I propose changing to post total accumulative wh

This Input can then have a 0.001 scale applied in Emoncms input processing and logged to a Feed using wh_accumlator Emoncms input process. This will ensure that even when the OpenEVSE EEPROM is erased and the total wh is lost Emoncms will preserve the value i.e wh_acculoator Emoncms feeds cannot go down, only up!

Here is a device template for the new device module (now live on Emoncm.org and emonPi) for the OpenEVSE to automate logging inputs correctly to feeds:

https://github.com/emoncms/device/blob/master/data/OpenEnergyMonitor/openevse.json

@jeremypoulter
Copy link
Collaborator

This is kind of a breaking change, may be best to add a #define to enable the old behaviour or add the wh as a different name

@glynhudson
Copy link
Contributor Author

Indeed, it's a breaking change, however, posting watt seconds was so unuseful I doubt anyone will have made use of it. I tried to but in my experience, the large numbers it generated seemed to crash Emoncms. Probably an overflow issue. I can't see anyone wanted to revert ws. My vote would be just to get rid of it for good avoid adding complexity. What do you think @chris1howell?

@chris1howell
Copy link
Member

chris1howell commented Nov 2, 2018 via email

@glynhudson glynhudson merged commit 2d8937a into master Nov 3, 2018
@glynhudson glynhudson deleted the emoncms-total-wh branch November 3, 2018 00:45
@glynhudson glynhudson mentioned this pull request Nov 3, 2018
Stef-Sijben pushed a commit to Stef-Sijben/ESP8266_WiFi_v2.x that referenced this pull request Apr 12, 2019
Post total wh to Emoncms instead of watt-seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants