od: Simplify model query in scripts #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/sys/firmware/devicetree/base/compatible is a \0-delimited file. Instead of relying on \0-removal and stripping the `ingenic.*` suffix, simply read the string up to the first \0. Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
Closed
|
This is actually much better, because you are using a built-in command instead of an external program. |
|
It unsets the default field separator, which means that whitespace will be preserved, e.g.: |
glebm
added a commit
to glebm/od-buildroot
that referenced
this pull request
Dec 11, 2023
`/sys/firmware/devicetree/base/compatible` is `\0`-delimited. Instead of relying on `\0`-removal and stripping the `ingenic.*` suffix, simply read the string up to the first `\0`. Follow-up to OpenDingux#97 which did this for other script. Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
pcercuei
pushed a commit
that referenced
this pull request
Mar 11, 2024
`/sys/firmware/devicetree/base/compatible` is `\0`-delimited. Instead of relying on `\0`-removal and stripping the `ingenic.*` suffix, simply read the string up to the first `\0`. Follow-up to #97 which did this for other script. Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sys/firmware/devicetree/base/compatibleis\0-delimited.Instead of relying on
\0-removal and stripping theingenic.*suffix, simply read the string up to the first\0.