Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial property tables #711

Merged
merged 9 commits into from
Aug 20, 2021
Merged

Conversation

ghutchis
Copy link
Member

Adds atom, bond, and residue displays (not edit)
Likely still has bugs, warts, crashes, etc.

Signed-off-by: Geoff Hutchison geoff.hutchison@gmail.com

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Adds atom, bond, and residue displays (not edit)
Likely still has bugs, warts, crashes, etc.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis linked an issue Jul 30, 2021 that may be closed by this pull request
4 tasks
@ghutchis ghutchis mentioned this pull request Jul 30, 2021
4 tasks
@github-actions
Copy link
Contributor

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis changed the title Initial draft of property tables WIP: Draft of property tables Jul 30, 2021
ghutchis added 2 commits July 30, 2021 16:44
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis added the enhancement feature changes / API changes label Aug 8, 2021
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
…roperty-tables

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis changed the title WIP: Draft of property tables Initial property tables Aug 17, 2021
@ghutchis
Copy link
Member Author

ghutchis commented Aug 17, 2021

A few remaining bugs:

  • clicking on a row doesn't seem to select it, despite the selection flags being returned
  • sometimes leaves extra atom / bond rows

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@avo-bot
Copy link

avo-bot commented Aug 17, 2021

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/property-tables-preview/3590/2

@github-actions
Copy link
Contributor

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member Author

I'm merging this as "works great for display"

@ghutchis ghutchis merged commit e81b4fe into OpenChemistry:master Aug 20, 2021
@ghutchis ghutchis deleted the property-tables branch August 20, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature changes / API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properties Tables
2 participants