Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to include .smiles in "need to --gen3d" #661

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

ghutchis
Copy link
Member

@ghutchis ghutchis commented Jul 9, 2021

Thanks to @drew-parsons should fix #657

Signed-off-by: Geoff Hutchison geoff.hutchison@gmail.com

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Thanks to @drew-parsons should fix OpenChemistry#657

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Copy link
Contributor

@drew-parsons drew-parsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch runs successfully. obabel now launches with -ismiles and with --gen3d added.

@ghutchis ghutchis merged commit 32eab8c into OpenChemistry:master Jul 9, 2021
@ghutchis ghutchis deleted the fix-insert-smiles-657 branch July 9, 2021 16:57
@ghutchis ghutchis added the bug label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert SMILES does not generate the requested molecule
2 participants