Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select atoms does not work when only wireframe is displayed #1127

Closed
mkgilson opened this issue Aug 23, 2022 · 6 comments · Fixed by #1128
Closed

Select atoms does not work when only wireframe is displayed #1127

mkgilson opened this issue Aug 23, 2022 · 6 comments · Fixed by #1128

Comments

@mkgilson
Copy link

Avogadro version: (please complete the following information from the About box):

  • Avogadrolibs: 1.97.0
  • Qt: 5.15.2

Desktop version: (please complete the following information):

  • OS: Windows
  • Version 10.0.19044 Build 19044
  • Compiler: N/A

Describe the bug
Mouse selection of atoms does not work for the wireframe molecular representation. (It does work for e.g. ball and stick.)

To Reproduce
Steps to reproduce the behavior:

  1. Load a molecule as a PDB file
  2. Click on Selection Tool
  3. Use left mouse button to drag and in principle select some atoms onscreen
  4. No atoms are highlighted. Clicking the Delete key does not delete the atoms that should have been selected

Expected behavior
Selection of atoms with mouse should work in wireframe representation

Screenshots
Non

Additional context
Add any other context about the problem here. Please consider uploading or linking test files.

@welcome
Copy link

welcome bot commented Aug 23, 2022

Thanks for opening your first issue here! Please try to include example files and screenshots if possible. If you're looking for support, please post on our forum: https://discuss.avogadro.cc/

@ghutchis
Copy link
Member

Thanks, I can confirm. Wireframe will show selected atoms (e.g., select by element or residue commands) but not the selection tool.

I'll look into this soon.

ghutchis added a commit to ghutchis/avogadrolibs that referenced this issue Aug 24, 2022
Previously, no AtomType rendering was presented.
Fix OpenChemistry#1127

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@mkgilson
Copy link
Author

Thanks for looking into this!

@ghutchis
Copy link
Member

This was an easy one. Seeing the issue pop up, I knew where the bug would be.

On the other hand, it exposed a much weirder selection bug (#1129).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants