Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wire_gen file and add makefile #199

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Rename wire_gen file and add makefile #199

merged 2 commits into from
Dec 6, 2024

Conversation

Yiling-J
Copy link
Member

@Yiling-J Yiling-J commented Dec 6, 2024

What is this feature?

Add makefile and rename wire_gen.go to wire_gen_test.go.

Why do we need this feature?

Currently, the wire_gen.go file in component package is only used in component tests. It is better to rename it to wire_gen_test.go for clarity and consistency. This change also helps prevent issues with Mockery generation. Mockery checks all files in the component package, except for those with the _test.go suffix. If any component interface changes, the wire_gen.go file might fail to build, blocking Mockery from running. However, renaming it to wire_gen_test.go ensures that Mockery will not check this file, avoiding potential build failures.

To regenerate wire_gen_test.go in component package, please use the make mock_wire command. Do not use the wire ./... command directly.

@starship-github
Copy link

The StarShip CodeReviewer was triggered but terminated because it encountered an issue: No files need to be reviewed based on the configured file extension policy.

Tips

CodeReview Commands (invoked as MR or PR comments)

  • @codegpt /review to trigger an code review.
  • @codegpt /evaluate to trigger code evaluation process.
  • @codegpt /describe to regenerate the summary of the MR.
  • @codegpt /secscan to scan security vulnerabilities for the MR or the Repository.
  • @codegpt /help to get help.

CodeReview Discussion Chat

There are 2 ways to chat with Starship CodeReview:

  • Review comments: Directly reply to a review comment made by StarShip.
    Example:
    • @codegpt How to fix this bug?
  • Files and specific lines of code (under the "Files changed" tab):
    Tag @codegpt in a new review comment at the desired location with your query.
    Examples:
    • @codegpt generate unit testing code for this code snippet.

Note: Be mindful of the bot's finite context window.
It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.
For a focused discussion, use review comments to chat about specific files and their changes, instead of using the MR/PR comments.

CodeReview Documentation and Community

  • Visit our Documentation
    for detailed information on how to use Starship CodeReview.

Copy link
Collaborator

@ganisback ganisback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yiling-J Yiling-J merged commit 6ad3fe7 into main Dec 6, 2024
4 checks passed
@Yiling-J Yiling-J deleted the oss/makefile branch December 6, 2024 05:30
@starship-github
Copy link

The StarShip CodeReviewer was triggered but terminated because it encountered an issue: The MR state is not opened.

Tips

CodeReview Commands (invoked as MR or PR comments)

  • @codegpt /review to trigger an code review.
  • @codegpt /evaluate to trigger code evaluation process.
  • @codegpt /describe to regenerate the summary of the MR.
  • @codegpt /secscan to scan security vulnerabilities for the MR or the Repository.
  • @codegpt /help to get help.

CodeReview Discussion Chat

There are 2 ways to chat with Starship CodeReview:

  • Review comments: Directly reply to a review comment made by StarShip.
    Example:
    • @codegpt How to fix this bug?
  • Files and specific lines of code (under the "Files changed" tab):
    Tag @codegpt in a new review comment at the desired location with your query.
    Examples:
    • @codegpt generate unit testing code for this code snippet.

Note: Be mindful of the bot's finite context window.
It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.
For a focused discussion, use review comments to chat about specific files and their changes, instead of using the MR/PR comments.

CodeReview Documentation and Community

  • Visit our Documentation
    for detailed information on how to use Starship CodeReview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants