Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various script fixes #9

Merged

Conversation

synackd
Copy link
Contributor

@synackd synackd commented May 10, 2024

Fixed:

build-test-image.sh:

  • Login prompt not showing (unmask getty and systemd-logind)

build-test-image-scratch.sh:

  • DNF cache not being found

s3-utils.sh:

  • PATH is set right no matter from where script is sourced from.

If running se-setup.sh e.g. from the ochami-vm repo root:

[user@host ochami-vm]$ pwd
/home/user/ochami-vm
[user@host ochami-vm]$ ./s3-utils/s3-setup.sh
[user@host ochami-vm]$ echo $PATH
...:/home/user/ochami-vm/bin

Running s3-setup.sh puts '/home/user/ochami-vm/bin' in the PATH when it should be '/home/user/ochami-vm/s3-utils/bin'.

This commit fixes this so no matter from which working directory the script is run from, the correct path is put into PATH.
@travisbcotton travisbcotton merged commit dbefc86 into OpenCHAMI:trcotton/vm-update May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants