Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Apply the same changes to the connected peers page. #688

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

jjeffryes
Copy link
Contributor

Just a tweak so the connected peers page gets the same changes as the follow tabs. Otherwise the layout breaks.

@jjeffryes jjeffryes mentioned this pull request Aug 18, 2017
@rmisio
Copy link
Contributor

rmisio commented Aug 18, 2017

Hmmm.... I didn't realize the connected peers page uses the userPage styling, which is a bit confusing. I think we probably did it this way because we thought this was a temporary page. If this does end up being a more permanent page, we should probably break out the common css into some common module (userCards or something) - but we could circle back to that.

@rmisio rmisio merged commit 94ba714 into follow-refactor Aug 18, 2017
@jjeffryes
Copy link
Contributor Author

Hmmm.... I didn't realize the connected peers page uses the userPage styling, which is a bit confusing. I think we probably did it this way because we thought this was a temporary page. If this does end up being a more permanent page, we should probably break out the common css into some common module (userCards or something) - but we could circle back to that.

It was definitely considered a temporary thing for testing, there's an issue to make it nicer, #581 eventually. When we do that it should get it's own styles or the styles should be made common.

@jjeffryes jjeffryes deleted the patchConnectedPeers branch October 9, 2017 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants