This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Delete entire stats object when saving. #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you mean remove it from what we're sending back to the server, then no. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the profile was edited, it was sending
which caused the server to return values of 0 for all the stats child objects.
Since we shouldn't be overwriting the stats object at all, this PR removes it on non-read syncs instead of removing specific children.
@rmisio do you know of a reason we wouldn't want to just remove the stats object? My assumption is the postCount attribute was added to the server and we didn't catch it, which created this bug. That attribute isn't used for anything in the client as far as I can tell.
Closes #656
This may close this server bug OpenBazaar/openbazaar-go#696