-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
@morebrownies What do you think of the styling of that link? My concern is that I'm not sure users will know it's clickable. |
styles/components/_misc.scss
Outdated
@@ -95,6 +95,10 @@ | |||
} | |||
} | |||
|
|||
#scamWarning { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be theme friendly, instead of hard coding this color, just add the clrTErr
class to the anchor.
@@ -45,3 +45,8 @@ <h3> | |||
<span class="js-closeNote"><%= ob.polyT('purchase.closeNote') %></span> | |||
<% } %> | |||
</div> | |||
<div class="padSm txSm txCtr"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to add purchase.scamWarning
to the translation file? I'm not seeing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Could put an underline on the "Protect against scams" text @rmisio |
Just realized this is a PR, @hoffmabc add underline to the text and I think it's good |
Ok I will update the css. I did update the language file but I must have missed the commit. |
https://scamprevention.openbazaar.org goes nowhere |
@ab10460ef3 we know. @hoffmabc hasn't set that up yet, he's travelling. We'll put a page there as soon as he's able to. |
I can set it up this evening to point somewhere live. |
The intention of this PR is to get the conversation rolling on this since it's super low priority.
Have at it fellas!