Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add scam warning to purchase modal #1164

Merged
merged 6 commits into from
Jan 9, 2018
Merged

Add scam warning to purchase modal #1164

merged 6 commits into from
Jan 9, 2018

Conversation

hoffmabc
Copy link
Member

@hoffmabc hoffmabc commented Jan 5, 2018

The intention of this PR is to get the conversation rolling on this since it's super low priority.

Have at it fellas!

image

@rmisio
Copy link
Contributor

rmisio commented Jan 5, 2018

@morebrownies What do you think of the styling of that link? My concern is that I'm not sure users will know it's clickable.

@@ -95,6 +95,10 @@
}
}

#scamWarning {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be theme friendly, instead of hard coding this color, just add the clrTErr class to the anchor.

@@ -45,3 +45,8 @@ <h3>
<span class="js-closeNote"><%= ob.polyT('purchase.closeNote') %></span>
<% } %>
</div>
<div class="padSm txSm txCtr">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to add purchase.scamWarning to the translation file? I'm not seeing it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@morebrownies
Copy link

Could put an underline on the "Protect against scams" text @rmisio

@morebrownies
Copy link

Just realized this is a PR, @hoffmabc add underline to the text and I think it's good

@rmisio
Copy link
Contributor

rmisio commented Jan 5, 2018

Just realized this is a PR, @hoffmabc add underline to the text and I think it's good

Yeah @hoffmabc, just give it a txU class.

@hoffmabc
Copy link
Member Author

hoffmabc commented Jan 5, 2018

Ok I will update the css. I did update the language file but I must have missed the commit.

@hoffmabc hoffmabc changed the title Add scam warning to purchase modal Add scam warning to purchase modal [WIP] Jan 9, 2018
@hoffmabc hoffmabc changed the title Add scam warning to purchase modal [WIP] Add scam warning to purchase modal Jan 9, 2018
@jjeffryes jjeffryes merged commit 53e63e8 into master Jan 9, 2018
@jjeffryes jjeffryes deleted the add-warning-link branch January 9, 2018 16:38
@ab10460ef3
Copy link
Contributor

https://scamprevention.openbazaar.org goes nowhere

@jjeffryes
Copy link
Contributor

@ab10460ef3 we know. @hoffmabc hasn't set that up yet, he's travelling. We'll put a page there as soon as he's able to.

@hoffmabc
Copy link
Member Author

I can set it up this evening to point somewhere live.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants