[backend] add query to fetch documents #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
============================================
- Coverage 25.32% 25.00% -0.32%
+ Complexity 961 956 -5
============================================
Files 466 466
Lines 10334 10333 -1
Branches 497 497
============================================
- Hits 2617 2584 -33
- Misses 7657 7690 +33
+ Partials 60 59 -1 ☔ View full report in Codecov by Sentry. |
RomuDeuxfois
requested changes
May 24, 2024
|
|
||
| public interface RawDocument { | ||
|
|
||
| String getDocument_Id(); |
| "left join tags tg on tg.tag_id = tagdoc.tag_id " + | ||
| "group by d.document_id " + | ||
| "order by document_id desc ", nativeQuery = true ) | ||
| List<RawDocument> findAllDocuments(); |
There was a problem hiding this comment.
Can you stick to the nomenclature?
rawAllDocuments()
and rawAllDocumentsByUser()
findAll is reserved for Document
There was a problem hiding this comment.
Roger that
RomuDeuxfois
approved these changes
May 24, 2024
RomuDeuxfois
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...