Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix thatMustBeFinisehd query to exclude disabled injects fr… #2092

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

guillaumejparis
Copy link
Member

…om count (#2091)

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.72%. Comparing base (85d9bf4) to head (828a904).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2092      +/-   ##
============================================
+ Coverage     33.43%   33.72%   +0.29%     
- Complexity     1668     1684      +16     
============================================
  Files           574      574              
  Lines         16800    16830      +30     
  Branches        992     1001       +9     
============================================
+ Hits           5617     5676      +59     
+ Misses        10929    10889      -40     
- Partials        254      265      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejparis guillaumejparis merged commit fece7c2 into master Dec 17, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/2091 branch December 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I have some disabled inject, simulation still On Going
2 participants