[backend] Fix cron test failed #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2036 +/- ##
=========================================
Coverage 33.43% 33.43%
Complexity 1668 1668
=========================================
Files 574 574
Lines 16799 16799
Branches 992 992
=========================================
Hits 5617 5617
Misses 10928 10928
Partials 254 254 ☔ View full report in Codecov by Sentry. |
savacano28
reviewed
Dec 11, 2024
| + " " | ||
| + zonedDateTime.getHour() | ||
| + " * * *"); // Every day now + 1 minute | ||
| "0 " + minuteToStart + " " + hourToStart + " * * *"); // Every day now + 1 minute | ||
| Scenario scenarioSaved = this.scenarioService.createScenario(scenario); |
There was a problem hiding this comment.
The message is correct if minuteTostart is 0 (cron : 0 0 0 * * *)?
There was a problem hiding this comment.
I am not sure to understand what you say
savacano28
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cron test to avoid failing on Xh 59 minutes.