Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] change app routing /exercises to /simulations (#1940) #1944

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

guillaumejparis
Copy link
Member

@guillaumejparis guillaumejparis commented Nov 27, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.62%. Comparing base (f4b3d9c) to head (d910560).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1944   +/-   ##
=========================================
  Coverage     33.62%   33.62%           
  Complexity     1671     1671           
=========================================
  Files           572      572           
  Lines         16697    16697           
  Branches        970      970           
=========================================
  Hits           5614     5614           
  Misses        10829    10829           
  Partials        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois self-requested a review November 28, 2024 07:51
@RomuDeuxfois RomuDeuxfois merged commit eb0d6aa into master Nov 28, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1940 branch November 28, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulations context - Rename 'exercices' in URL for 'simulations
2 participants