[frontend/backend] correct logout redirection #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
github-actions
bot
added
the
filigran team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1790 +/- ##
============================================
+ Coverage 32.07% 32.12% +0.05%
- Complexity 1609 1626 +17
============================================
Files 561 561
Lines 16845 17119 +274
Branches 973 1009 +36
============================================
+ Hits 5403 5500 +97
- Misses 11198 11373 +175
- Partials 244 246 +2 ☔ View full report in Codecov by Sentry. |
…page Signed-off-by: Marine LM <marine.lemezo@filigran.io>
damgouj
approved these changes
Oct 31, 2024
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
MarineLeM
changed the title
| @@ -92,7 +93,7 @@ public ValidationErrorBag handleBadRequestExceptions(ImportException ex) { | |||
| } | |||
|
|
|||
| @ResponseStatus(HttpStatus.UNAUTHORIZED) | |||
| @ExceptionHandler(AccessDeniedException.class) | |||
| @ExceptionHandler(AuthenticationException.class) | |||
| public ValidationErrorBag handleValidationExceptions() { | |||
| ValidationErrorBag bag = | |||
| new ValidationErrorBag(HttpStatus.UNAUTHORIZED.value(), "ACCESS_DENIED"); | |||
There was a problem hiding this comment.
Maybe change default message for something more meaningful as UNATHORIZED is described as : "it lacks valid authentication credentials for the requested resource"
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
guillaumejparis
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close : #1778
The user creation functionality worked correctly.
However, the issue was when clicking the logout button: the page displayed the login form, but the URL did not update accordingly.
Moreover i update the status code in the back
when a user is connected but don't have access the api return 404
when a user is not connected anymore and want to have access to some information the api return 401