Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix uri definition variables #1651

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Oct 16, 2024

Proposed changes

  • Fix url for Manage custom variables on scenario, exercise, quick inject and atomic testing
  • On atomic testing page : Currently, we dont have the option for custom variables :
    image
  • On scenario, exercise, we redirect to /definition for Manage the custom variables :
    image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Oct 16, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.22%. Comparing base (7e2ac6c) to head (4997d53).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1651      +/-   ##
============================================
+ Coverage     32.91%   33.22%   +0.30%     
- Complexity     1573     1586      +13     
============================================
  Files           550      551       +1     
  Lines         14426    14451      +25     
  Branches        873      873              
============================================
+ Hits           4749     4802      +53     
+ Misses         9456     9428      -28     
  Partials        221      221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review October 16, 2024 16:23
@savacano28 savacano28 force-pushed the bugfix/1473-diplay-uri branch 2 times, most recently from cf43b6e to b200a73 Compare October 16, 2024 16:27
@savacano28 savacano28 changed the title [backend] Fix uri definition variables [frontend] Fix uri definition variables Oct 16, 2024
@MarineLeM MarineLeM self-requested a review October 17, 2024 07:24
@savacano28 savacano28 force-pushed the bugfix/1473-diplay-uri branch from d33952a to a2bfc78 Compare October 17, 2024 08:52
MarineLeM
MarineLeM previously approved these changes Oct 17, 2024
@savacano28 savacano28 requested a review from MarineLeM October 17, 2024 09:53
@savacano28 savacano28 dismissed MarineLeM’s stale review October 17, 2024 09:54

wait for last part of fix

@MarineLeM
Copy link
Contributor

There is a problem to display the 'teams' variable

@MarineLeM MarineLeM self-assigned this Oct 17, 2024
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
@savacano28 savacano28 merged commit 946652b into master Oct 17, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/1473-diplay-uri branch October 20, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ UI improvement ] to display uri of a media pressure in an email inject
2 participants