Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix on count in atomic testing search #1168

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Jun 27, 2024

Proposed changes

  • Small change to fix the count in atomic testing

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.17%. Comparing base (bb9aeb6) to head (b7843d9).

Files Patch % Lines
.../java/io/openbas/service/AtomicTestingService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1168      +/-   ##
============================================
+ Coverage     25.90%   26.17%   +0.27%     
- Complexity     1062     1066       +4     
============================================
  Files           481      481              
  Lines         11602    11602              
  Branches        609      609              
============================================
+ Hits           3005     3037      +32     
+ Misses         8512     8480      -32     
  Partials         85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion merged commit 6f6f545 into master Jun 28, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the bugfix/incorrect_atomic_testing_count branch June 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants