Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix crash page atomic testing after deleting a payload #1160

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jun 26, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jun 26, 2024
@savacano28 savacano28 self-assigned this Jun 26, 2024
@savacano28 savacano28 marked this pull request as ready for review June 26, 2024 12:59
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.17%. Comparing base (827af72) to head (24e795b).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1160   +/-   ##
=========================================
  Coverage     26.17%   26.17%           
  Complexity     1066     1066           
=========================================
  Files           481      481           
  Lines         11602    11602           
  Branches        609      609           
=========================================
  Hits           3037     3037           
  Misses         8480     8480           
  Partials         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the bug/1141 branch 4 times, most recently from f1973a3 to e65c4b0 Compare June 28, 2024 09:54
@savacano28 savacano28 requested a review from Dimfacion June 28, 2024 09:55
@savacano28
Copy link
Contributor Author

Create ticket about how a deleted payload could be shown in scenario, exercise, atomic testing..

Copy link
Member

@Dimfacion Dimfacion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@savacano28 savacano28 merged commit bd58467 into master Jun 28, 2024
6 checks passed
@savacano28 savacano28 deleted the bug/1141 branch June 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After deleting a payload, atomic testing is throwing an error when accessing
2 participants