Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix options for tone in message (#1126) #1155

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jun 25, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 linked an issue Jun 25, 2024 that may be closed by this pull request
@savacano28 savacano28 self-assigned this Jun 25, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jun 25, 2024
@savacano28 savacano28 marked this pull request as ready for review June 25, 2024 13:14
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.17%. Comparing base (bd58467) to head (6e756d6).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1155   +/-   ##
=========================================
  Coverage     26.17%   26.17%           
  Complexity     1066     1066           
=========================================
  Files           481      481           
  Lines         11602    11602           
  Branches        609      609           
=========================================
  Hits           3037     3037           
  Misses         8480     8480           
  Partials         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the bug/1126 branch 4 times, most recently from 635b1e9 to 6392238 Compare June 27, 2024 13:04
@savacano28 savacano28 force-pushed the bug/1126 branch 3 times, most recently from 9654628 to 5749dc2 Compare June 28, 2024 12:49
@savacano28
Copy link
Contributor Author

Product told me to keep this order.

Copy link
Member

@Dimfacion Dimfacion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then :)

Signed-off-by: Stephanya Casanova <stephanya.casanova@filigran.io>
@savacano28 savacano28 merged commit 7de2a39 into master Jun 28, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the bug/1126 branch June 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using change tone for an existing email is displaying wrong options
2 participants