Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix null pointer exc #1144

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jun 24, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.66%. Comparing base (0b9ca6a) to head (6068797).

Files Patch % Lines
...rc/main/java/io/openbas/service/InjectService.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1144      +/-   ##
============================================
- Coverage     26.67%   26.66%   -0.01%     
  Complexity     1067     1067              
============================================
  Files           474      474              
  Lines         11323    11325       +2     
  Branches        579      579              
============================================
  Hits           3020     3020              
- Misses         8219     8221       +2     
  Partials         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Dimfacion Dimfacion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Nitpick : The name of your branch does not match what is described in the internal docs.
Does the naming described here not fit your need ?

@savacano28 savacano28 added technical improvement Technical refactor or improvement is needed filigran team use to identify PR from the Filigran team labels Jun 24, 2024
@savacano28 savacano28 self-assigned this Jun 24, 2024
@savacano28 savacano28 merged commit 47afe03 into master Jun 24, 2024
6 checks passed
@savacano28 savacano28 deleted the bugfix/nullpointer-inject-assets branch June 25, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants