Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Add pagination in exercise list and improv performance #1090

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

RomuDeuxfois
Copy link
Member

Proposed changes

  • Add pagination in exercise list
  • Improv performance on exercise list

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 1.09890% with 180 lines in your changes missing coverage. Please review.

Project coverage is 26.84%. Comparing base (0ab5ff1) to head (e389311).

Files Patch % Lines
...java/io/openbas/rest/exercise/ExerciseService.java 1.49% 66 Missing ⚠️
...ain/java/io/openbas/rest/exercise/ExerciseApi.java 0.00% 62 Missing ⚠️
...rc/main/java/io/openbas/service/InjectService.java 0.00% 46 Missing ⚠️
.../io/openbas/rest/scenario/ScenarioExerciseApi.java 16.66% 5 Missing ⚠️
.../io/openbas/rest/exercise/form/ExerciseSimple.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1090      +/-   ##
============================================
+ Coverage     26.82%   26.84%   +0.01%     
- Complexity     1057     1062       +5     
============================================
  Files           469      471       +2     
  Lines         11105    11192      +87     
  Branches        562      567       +5     
============================================
+ Hits           2979     3004      +25     
- Misses         8041     8104      +63     
+ Partials         85       84       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 18, 2024
Copy link
Contributor

@Christian-DONGMO Christian-DONGMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good.

@RomuDeuxfois RomuDeuxfois force-pushed the improvment/exercises branch from be049b9 to e389311 Compare June 20, 2024 07:34
@RomuDeuxfois RomuDeuxfois merged commit fedc5b4 into master Jun 20, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the improvment/exercises branch June 20, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants