Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Fixing full text search wrong indicators #1075

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Jun 12, 2024

Proposed changes

  • Fixing the wrong indicators
  • Adding a way to search for an id
  • Fixing the search bar not updating when going on the search from a url

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 25.33%. Comparing base (dae2a50) to head (d7b2d57).
Report is 3 commits behind head on master.

Files Patch % Lines
.../java/io/openbas/search/FullTextSearchService.java 41.17% 10 Missing ⚠️
...a/io/openbas/utils/pagination/PaginationUtils.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1075      +/-   ##
============================================
+ Coverage     25.27%   25.33%   +0.06%     
  Complexity     1010     1010              
============================================
  Files           464      464              
  Lines         10893    10892       -1     
  Branches        534      534              
============================================
+ Hits           2753     2760       +7     
+ Misses         8074     8066       -8     
  Partials         66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion requested a review from RomuDeuxfois June 14, 2024 12:56
@Dimfacion Dimfacion added this to the Release 1.1.0 milestone Jun 14, 2024
@Dimfacion Dimfacion self-assigned this Jun 14, 2024
@Dimfacion Dimfacion modified the milestones: Release 1.1.0, Bugs backlog Jun 14, 2024
@Dimfacion Dimfacion merged commit 5e0a0db into master Jun 14, 2024
6 checks passed
@SamuelHassine SamuelHassine removed this from the Bugs backlog milestone Jun 15, 2024
@Dimfacion Dimfacion deleted the issue/1017 branch September 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants