Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Fix import #1069

Merged
merged 5 commits into from
Jun 14, 2024
Merged

[backend/frontend] Fix import #1069

merged 5 commits into from
Jun 14, 2024

Conversation

RomuDeuxfois
Copy link
Member

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 44.55446% with 112 lines in your changes missing coverage. Please review.

Project coverage is 26.67%. Comparing base (3366c8a) to head (e7660a4).
Report is 3 commits behind head on master.

Files Patch % Lines
...main/java/io/openbas/importer/V1_DataImporter.java 50.60% 69 Missing and 12 partials ⚠️
...as/rest/exercise/exports/ExerciseExportMixins.java 0.00% 16 Missing ⚠️
...rc/main/java/io/openbas/rest/inject/InjectApi.java 11.11% 8 Missing ⚠️
...ain/java/io/openbas/rest/exercise/ExerciseApi.java 0.00% 5 Missing ⚠️
...s/migration/V3_16__Add_array_union_agg_method.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1069      +/-   ##
============================================
+ Coverage     25.60%   26.67%   +1.06%     
- Complexity     1014     1046      +32     
============================================
  Files           464      464              
  Lines         10877    10996     +119     
  Branches        532      562      +30     
============================================
+ Hits           2785     2933     +148     
+ Misses         8026     7978      -48     
- Partials         66       85      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review June 12, 2024 09:46
@Dimfacion
Copy link
Member

Probleme de Prod_2024-06-13T14_32_02.159342300Z_(with_teams & with_players & with_variable_values).zip
As seen together, I've had NPE with this import zip

Optional<Tag> findByName(@NotNull String name);
@NotNull
Optional<Tag> findByName(@NotNull final String name);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also add an ignoreCase here? Do we have a unique constraint on this column?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have it :)

@NotNull
List findByNameIgnoreCase(@NotNull final String name);

@RomuDeuxfois
Copy link
Member Author

RomuDeuxfois commented Jun 13, 2024

Probleme de Prod_2024-06-13T14_32_02.159342300Z_(with_teams & with_players & with_variable_values).zip As seen together, I've had NPE with this import zip

It's fixed, and it revealed another bug.
We no longer link the documents to the exercise when creating an inject in an exercise.

@RomuDeuxfois RomuDeuxfois merged commit 6c12f36 into master Jun 14, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1067 branch June 14, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a simulation creates an error message or create the simulation completely empty
3 participants