Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improv performance on challenges #1066

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois force-pushed the improvment/challenges branch from c0acb70 to 4e6eab1 Compare June 7, 2024 15:34
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 72.88136% with 16 lines in your changes missing coverage. Please review.

Project coverage is 26.36%. Comparing base (9defb91) to head (4e6eab1).

Files Patch % Lines
...o/openbas/rest/challenge/ExerciseChallengeApi.java 10.00% 9 Missing ⚠️
...ava/io/openbas/rest/challenge/ChallengeHelper.java 66.66% 2 Missing and 1 partial ⚠️
...openbas/rest/challenge/output/ChallengeOutput.java 89.65% 2 Missing and 1 partial ⚠️
...n/java/io/openbas/rest/challenge/ChallengeApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1066      +/-   ##
============================================
+ Coverage     25.87%   26.36%   +0.49%     
- Complexity     1007     1024      +17     
============================================
  Files           451      455       +4     
  Lines         10568    10621      +53     
  Branches        513      514       +1     
============================================
+ Hits           2734     2800      +66     
+ Misses         7771     7756      -15     
- Partials         63       65       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Christian-DONGMO Christian-DONGMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything sound good

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 10, 2024
@RomuDeuxfois RomuDeuxfois merged commit a41c76c into master Jun 11, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the improvment/challenges branch June 11, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants