Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improv performance on articles #1064

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

RomuDeuxfois
Copy link
Member

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 72.50000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 26.51%. Comparing base (a059c30) to head (b651bd9).
Report is 1 commits behind head on master.

Files Patch % Lines
...in/java/io/openbas/rest/channel/ChannelHelper.java 70.37% 8 Missing ⚠️
...va/io/openbas/rest/channel/ExerciseArticleApi.java 11.11% 8 Missing ⚠️
.../main/java/io/openbas/rest/channel/ChannelApi.java 33.33% 4 Missing ⚠️
.../io/openbas/rest/channel/output/ArticleOutput.java 93.10% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1064      +/-   ##
============================================
+ Coverage     26.17%   26.51%   +0.34%     
- Complexity     1011     1028      +17     
============================================
  Files           451      455       +4     
  Lines         10568    10619      +51     
  Branches        513      513              
============================================
+ Hits           2766     2816      +50     
+ Misses         7739     7738       -1     
- Partials         63       65       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return this.virtualPublication != null;
}

public static ArticleOutput from(@org.jetbrains.annotations.NotNull final Article article) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use jakarta.validation.constraints.NotNull instead of org.jetbrains.annotations.NotNull

Copy link
Contributor

@Christian-DONGMO Christian-DONGMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a comment about annotation. Otherwise, everything else looks good to me

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 10, 2024
@RomuDeuxfois RomuDeuxfois merged commit 379d4ac into master Jun 11, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the improvment/article branch June 11, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants