Issue/917 inject result for media pressure image broken link #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding injectIcon tag to commute when the collector id is null
Adding icon to channel preview page
Resolved broken links into mails
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
============================================
+ Coverage 25.87% 26.17% +0.30%
- Complexity 1007 1011 +4
============================================
Files 451 451
Lines 10568 10568
Branches 513 513
============================================
+ Hits 2734 2766 +32
+ Misses 7771 7739 -32
Partials 63 63 ☔ View full report in Codecov by Sentry. |
RomuDeuxfois
requested changes
Jun 7, 2024
openbas-front/src/public/components/channels/ChannelNewspaper.js
Outdated
Show resolved
Hide resolved
openbas-front/src/public/components/channels/ChannelNewspaper.js
Outdated
Show resolved
Hide resolved
openbas-front/src/public/components/channels/ChannelNewspaper.js
Outdated
Show resolved
Hide resolved
Resolved broken links into mails
…into issue/917_Inject-Result-for-media-pressure-image-broken-link
RomuDeuxfois
requested changes
Jun 10, 2024
| @@ -22,10 +22,6 @@ const useStyles = makeStyles(() => ({ | |||
| card: { | |||
| position: 'relative', | |||
| }, | |||
| logo: { | |||
There was a problem hiding this comment.
It's used on line 76
{classes.logo}
RomuDeuxfois
approved these changes
Jun 10, 2024
RomuDeuxfois
deleted the
issue/917_Inject-Result-for-media-pressure-image-broken-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...