Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] add policies page #1015

Merged
merged 24 commits into from
Jun 6, 2024
Merged

[backend/frontend] add policies page #1015

merged 24 commits into from
Jun 6, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented May 29, 2024

Proposed changes

image
image

image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 linked an issue May 29, 2024 that may be closed by this pull request
@savacano28 savacano28 self-assigned this May 29, 2024
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 9.41176% with 154 lines in your changes missing coverage. Please review.

Project coverage is 26.18%. Comparing base (dce8408) to head (1567e1f).

Files Patch % Lines
...va/io/openbas/service/PlatformSettingsService.java 9.03% 141 Missing ⚠️
.../io/openbas/rest/settings/PlatformSettingsApi.java 22.22% 7 Missing ⚠️
...ava/io/openbas/rest/settings/form/PolicyInput.java 0.00% 5 Missing ⚠️
...enbas/rest/settings/response/PlatformSettings.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1015      +/-   ##
============================================
+ Coverage     25.77%   26.18%   +0.40%     
- Complexity     1003     1010       +7     
============================================
  Files           449      450       +1     
  Lines         10587    10561      -26     
  Branches        514      513       -1     
============================================
+ Hits           2729     2765      +36     
+ Misses         7795     7733      -62     
  Partials         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review June 3, 2024 07:42
@savacano28 savacano28 changed the title [frontend] add policies page [backend/frontend] add policies page Jun 4, 2024
@RomuDeuxfois RomuDeuxfois merged commit 716ffe7 into master Jun 6, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/391 branch June 6, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to have a login message
2 participants