Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover icon inconsistency in lists #1659

Closed
SamuelHassine opened this issue Oct 17, 2024 · 2 comments · Fixed by #2054
Closed

Popover icon inconsistency in lists #1659

SamuelHassine opened this issue Oct 17, 2024 · 2 comments · Fixed by #2054
Assignees
@johanah29
Labels
bug use for describing something not working as expected solved The issue has been solved UI improvement
Milestone
Release 1.9.2

Comments

@SamuelHassine
Copy link
Member

Description

Correct (large icon, like in OpenCTI):

image

Scenarios / simulations / atomic testing, incorrect, small icon:

image

Need to be consistant across screens and design system, if we choose to go small, then sync with OpenCTI team to align. For the moment, it is large everywhere, so need to be fixed.
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Oct 17, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Oct 17, 2024 •
edited
Loading

@jborozco any input on this regarding which design decision to take ?

Indeed we don't have the same icon sizing across platforms at the minute 🙏
Screenshot 2024-10-17 111954
Screenshot 2024-10-17 111922

@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Oct 17, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Oct 17, 2024
@jborozco
Copy link

let's use the same size than octi indeed

@johanah29 johanah29 self-assigned this Dec 12, 2024
@johanah29 johanah29 linked a pull request Dec 12, 2024 that will close this issue
[Frontend]Correct popover icon (#1659) #2054
Merged
johanah29 added a commit that referenced this issue Dec 12, 2024
@johanah29
[Frontend]Correct popover icon (#1659)
8c3594e
@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Dec 13, 2024
heditar pushed a commit that referenced this issue Dec 13, 2024
@johanah29 @heditar
[Frontend]Correct popover icon (#1659)
c9eb79b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanah29 johanah29

Labels
bug use for describing something not working as expected solved The issue has been solved UI improvement
Projects
None yet
Milestone
Release 1.9.2
Development

Successfully merging a pull request may close this issue.

[Frontend]Correct popover icon (#1659) OpenBAS-Platform/openbas
5 participants
@SamuelHassine @EllynBsc @jborozco @johanah29 @RomuDeuxfois