Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not populating when RabbitMQ is using SSL #1618

Open
Dimfacion opened this issue Oct 4, 2024 · 4 comments · Fixed by #1622
Open

Settings not populating when RabbitMQ is using SSL #1618

Dimfacion opened this issue Oct 4, 2024 · 4 comments · Fixed by #1622
Assignees
Labels
bug use for describing something not working as expected
Milestone

Comments

@Dimfacion
Copy link
Member

Description

Environment

  1. OS (where OpenBAS server runs): any
  2. OpenBAS version: 1.7.0
  3. OpenBAS client: frontend
  4. Other environment details:

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Have a rabbitMQ with SSL
  2. Go to the settings page
  3. All settings do not populate and a call is returning a 500 error

Expected Output

No 500 error and settings populated

Actual Output

Additional information

Screenshots (optional)

@Dimfacion Dimfacion added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Oct 4, 2024
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Oct 4, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Oct 4, 2024
@Dimfacion
Copy link
Member Author

Dimfacion commented Oct 4, 2024

In the logs, we can see this :
java.lang.IllegalArgumentException: [https://] is not a valid HTTP URL
at org.springframework.web.util.UriComponentsBuilder.fromUriString(UriComponentsBuilder.java:247) ~[spring-web-6.1.1.jar!/:6.1.1]
at org.springframework.web.util.DefaultUriBuilderFactory$DefaultUriBuilder.initUriComponentsBuilder(DefaultUriBuilderFactory.java:248) ~[spring-web-6.1.1.jar!/:6.1.1]
at org.springframework.web.util.DefaultUriBuilderFactory$DefaultUriBuilder.(DefaultUriBuilderFactory.java:234) ~[spring-web-6.1.1.jar!/:6.1.1]
at org.springframework.web.util.DefaultUriBuilderFactory.uriString(DefaultUriBuilderFactory.java:161) ~[spring-web-6.1.1.jar!/:6.1.1]
at org.springframework.web.util.DefaultUriBuilderFactory.expand(DefaultUriBuilderFactory.java:154) ~[spring-web-6.1.1.jar!/:6.1.1]
at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:780) ~[spring-web-6.1.1.jar!/:6.1.1]
at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:663) ~[spring-web-6.1.1.jar!/:6.1.1]
at io.openbas.helper.RabbitMQHelper.getRabbitMQVersion(RabbitMQHelper.java:47) ~[!/:1.6.1]
at io.openbas.service.PlatformSettingsService.findSettings(PlatformSettingsService.java:210) ~[!/:1.6.1]
at io.openbas.rest.settings.PlatformSettingsApi.settings(PlatformSettingsApi.java:35) ~[!/:1.6.1]

This points to an issue with how we call rabbitMQ when SSL is activated.
Two possible solutions :

Suggestion : do not choose and add a way to have the call secured with the keystore or unsecured with an option in the properties

@RomuDeuxfois
Copy link
Member

Reopen because the RabbitMQ version is not displayed anymore

@EllynBsc EllynBsc removed the solved The issue has been solved label Oct 16, 2024
@jborozco jborozco removed the critical use to identify critical bug to fix ASAP label Oct 17, 2024
@jborozco
Copy link

jborozco commented Oct 17, 2024

Critical removed because our prospect qualified the bug as low impact

@jborozco jborozco modified the milestones: Release 1.7.1, Bugs backlog Oct 17, 2024
@RomuDeuxfois
Copy link
Member

@Dimfacion Do you have an ETA on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants