Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement - Show prerequisites info in payloads drawer #1518

Closed
jborozco opened this issue Sep 23, 2024 · 3 comments
Closed

UI improvement - Show prerequisites info in payloads drawer #1518

jborozco opened this issue Sep 23, 2024 · 3 comments
Assignees
Labels
feature use for describing a new feature to develop solved The issue has been solved
Milestone

Comments

@jborozco
Copy link

jborozco commented Sep 23, 2024

Use case

Example of payloads using scripts : https://github.com/redcanaryco/atomic-red-team/blob/bf6d97679d7f208ffbeb00f61b80e46ee676de3c/atomics/T1059/T1059.md?plain=1

  1. When I go the payload list and I click on a payload, I can't see the prerequisites command (get command AND check command). It's frustrating when you try a command and the prerequisites don't work when you didn't even see that they were needed.

377777753-9ab17544-5b42-427f-83a3-89c8045c4edf

  1. When I go the payload list and I click on a payload, I can't see the executor. It's frustrating when you try a command and the executor don't work when you didn't even see that they were needed.
    Add the executor on UI

Other UI improvements:
3. Add the arguments with their type, key and default value
4. Add the payload tags
5. Add the attack phase

@jborozco jborozco added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Sep 23, 2024
@jborozco jborozco added this to the Release 1.9.0 milestone Sep 23, 2024
@jborozco jborozco assigned jborozco and EllynBsc and unassigned jborozco Sep 30, 2024
@jborozco jborozco removed this from the Release 1.9.0 milestone Oct 18, 2024
@EllynBsc EllynBsc added this to the Release 1.9.0 milestone Oct 18, 2024
@savacano28 savacano28 self-assigned this Oct 23, 2024
@RomuDeuxfois RomuDeuxfois changed the title Manage prerequisits setup for atomic red team payloads Manage prerequisites setup for atomic red team payloads - UI Oct 28, 2024
@guillaumejparis
Copy link
Member

@jborozco Can we improve the ui and have all the commands take all the width of the drawer ?

@EllynBsc
Copy link
Member

Hi @guillaumejparis and @johanah29

I just saw the design implementation of @jborozco for the drawer - here it is

Available for a quick call if you want to discuss it!

Screenshot 2024-10-31 095700

@EllynBsc EllynBsc changed the title Manage prerequisites setup for atomic red team payloads - UI UI improvement - Manage prerequisites setup for atomic red team payloads Oct 31, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Nov 4, 2024

As agreed, replace the keyword 'content' or 'command' by 'attack command' in the payload drawer as well as in the execution details traces of the payload

@jborozco jborozco changed the title UI improvement - Manage prerequisites setup for atomic red team payloads UI improvement - Show prerequisites info in payloads and inject details Nov 8, 2024
@jborozco jborozco changed the title UI improvement - Show prerequisites info in payloads and inject details UI improvement - Show prerequisites info in payloads Nov 14, 2024
@jborozco jborozco changed the title UI improvement - Show prerequisites info in payloads UI improvement - Show prerequisites info in payloads drawer Nov 14, 2024
@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved The issue has been solved
Projects
None yet
Development

No branches or pull requests

6 participants