Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microsoft-defender] change implementation to not use TimeGenerated (#2035) #74

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

antoinemzs
Copy link
Contributor

@antoinemzs antoinemzs commented Dec 11, 2024

Proposed changes

  • Change query to not use TimeGenerated

A customer came back saying their version of the Threat Hunting schema did not have TimeGenerated columns on tables, contrary to our own. A mistake was made to rely on this column in the query that fetched alerts from the MDE backend.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@antoinemzs antoinemzs changed the title change implementation to not use TimeGenerated [microsoft-defender] change implementation to not use TimeGenerated (#2035) Dec 11, 2024
@antoinemzs antoinemzs added filigran team use to identify PR from the Filigran team do not merge Do not merge this PR until this tag will be removed labels Dec 11, 2024
@antoinemzs antoinemzs marked this pull request as ready for review December 12, 2024 13:51
@antoinemzs antoinemzs removed the do not merge Do not merge this PR until this tag will be removed label Dec 12, 2024
@antoinemzs antoinemzs merged commit 581ca28 into main Dec 12, 2024
2 checks passed
@antoinemzs antoinemzs deleted the issue/2035 branch December 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 400 with MDE collector
2 participants