-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microsoft-sentinel/microsoft-defender] Improve matching to identify Prevented and add match on parent process name (#1757) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isselparra
force-pushed
the
issue/1757
branch
from
November 5, 2024 15:22
d5a08a7
to
d778b7a
Compare
isselparra
force-pushed
the
issue/1757
branch
from
November 5, 2024 15:24
d778b7a
to
8607786
Compare
isselparra
commented
Nov 6, 2024
Comment on lines
126
to
134
def _extract_parent_process_name(self, columns_index, alert): | ||
parent_process_names = [] | ||
entities = json.loads(alert[columns_index["Entities"]]) | ||
for entity in entities: | ||
if "Type" in entity and entity["Type"] == "process": | ||
if "ParentProcess" in entity and "ImageFile" in entity["ParentProcess"]: | ||
if "ImageFile" in entity["ParentProcess"] and "Name" in entity["ParentProcess"]["ImageFile"]: | ||
parent_process_names.append(entity["ParentProcess"]["ImageFile"]["Name"]) | ||
return parent_process_names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking): ifs nesting could be removed/improved
def _extract_parent_process_name(self, columns_index, alert):
parent_process_names = []
entities = json.loads(alert[columns_index["Entities"]])
for entity in entities:
if (entity.get("Type") == "process" and
entity.get("ParentProcess", {}).get("ImageFile", {}).get("Name")):
parent_process_names.append(entity["ParentProcess"]["ImageFile"]["Name"])
return parent_process_names
isselparra
changed the title
[microsoft-sentinel] use alert name to verify if prevented
[microsoft-sentinel] Use alert name to verify if prevented
Nov 7, 2024
isselparra
changed the title
[microsoft-sentinel] Use alert name to verify if prevented
[microsoft-sentinel/microsoft-defender] Improve matching to identify Prevented and add match on parent process name
Nov 7, 2024
Test OK with Eicar, no regression with in the introduction of matching on parent_process_name |
RomuDeuxfois
approved these changes
Nov 7, 2024
isselparra
changed the title
[microsoft-sentinel/microsoft-defender] Improve matching to identify Prevented and add match on parent process name
[microsoft-sentinel/microsoft-defender] Improve matching to identify Prevented and add match on parent process name (#1757)
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments