fix: slaveof return #2158
Closed
fix: slaveof return #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixficsol
reviewed
Nov 22, 2023
src/pika_admin.cc
Outdated
| @@ -121,6 +121,11 @@ void SlaveofCmd::DoInitial() { | |||
| return; | |||
| } | |||
|
|
|||
| if((g_pika_server->role() & PIKA_ROLE_SLAVE) != 0 && master_ip_ != g_pika_server->host() && master_port_ != g_pika_server->port()) { | |||
| res_.SetRes(CmdRes::kErrOther, "Not the same master,please use salveof no one to return the single mode before binding to other cluster."); | |||
There was a problem hiding this comment.
一个小建议，符号后面留一个空格master, please
AlexStocks
approved these changes
Nov 22, 2023
|
目前问题是，如果一个集群里进行切主操作，那么这段代码就会返回错误，所以应该要找codis那层的逻辑 |
|
需要参照 Codis 的逻辑继续改进 |
|
wxr：需要跟一哥再讨论下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
ISSUES #1965
1和2可以看做为只要是从节点，再执行关于slaveof命令时，就返回错误
3的本质就是前面都包含了，我们规定是一个集群内的replicationid保持一致，如果replicationid不一致那么一定不是一个集群的