Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some compile warning #1861

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: fix some compile warning #1861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ fi
cd ${BUILD_DIR}

use_pika_tools=""
if [ $1 = "tools" ]; then
if [[ $1 = "tools" ]]; then
use_pika_tools="-DUSE_PIKA_TOOLS=ON"
fi

Expand Down
16 changes: 8 additions & 8 deletions include/pika_list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ class BlockingBaseCmd : public Cmd {
class BLPopCmd final : public BlockingBaseCmd {
public:
BLPopCmd(const std::string& name, int arity, uint16_t flag) : BlockingBaseCmd(name, arity, flag){};
virtual std::vector<std::string> current_key() const {
virtual std::vector<std::string> current_key() const override {
return { keys_ };
}
virtual void Do(std::shared_ptr<Slot> slot = nullptr);
virtual void Split(std::shared_ptr<Slot> slot, const HintKeys& hint_keys){};
virtual void Merge(){};
virtual void Do(std::shared_ptr<Slot> slot = nullptr) override;
virtual void Split(std::shared_ptr<Slot> slot, const HintKeys& hint_keys) override {};
virtual void Merge() override {};
virtual Cmd* Clone() override { return new BLPopCmd(*this); }
void DoInitial() override;
void DoBinlog(const std::shared_ptr<SyncMasterSlot>& slot) override;
Expand Down Expand Up @@ -257,12 +257,12 @@ class LTrimCmd : public Cmd {
class BRPopCmd final : public BlockingBaseCmd {
public:
BRPopCmd(const std::string& name, int arity, uint16_t flag) : BlockingBaseCmd(name, arity, flag){};
virtual std::vector<std::string> current_key() const {
virtual std::vector<std::string> current_key() const override {
return { keys_ };
}
virtual void Do(std::shared_ptr<Slot> slot = nullptr);
virtual void Split(std::shared_ptr<Slot> slot, const HintKeys& hint_keys){};
virtual void Merge(){};
virtual void Do(std::shared_ptr<Slot> slot = nullptr) override;
virtual void Split(std::shared_ptr<Slot> slot, const HintKeys& hint_keys) override {};
virtual void Merge() override {};
virtual Cmd* Clone() override { return new BRPopCmd(*this); }
void DoInitial() override;
void DoBinlog(const std::shared_ptr<SyncMasterSlot>& slot) override;
Expand Down