[swift5 client] fix filename for binary downloads #9989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a file download is handled within URLSessionImplementations,
the filename is retrieved via the header Content-Disposition part of the response.
The header is looked for an entry starting with filename=.
But the search is skipped too early, since the loop is exited if the first iteration does not match.
Example:
Try to download a file with a swift5 client for a spec like this:
When downloading from a server, the response header could have an answer like so:
There, the server says to use downloaded.pdf as filename. But the actual implementation of the swift5 client will exit after checking attachment and won't find
filename=
in the next section (separated by semicolon).Solution:
Simply replacing break with continue in the matching logic inside the loop fixes the algorithm.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.3.x
,6.0.x
@jgavris, @ehyche, @Edubits, @jaz-ah, @4brunu