Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-ue4] Improved retry system to use Unreal's FHttpRetrySystem #9382

Merged
merged 4 commits into from
May 6, 2021

Conversation

Kahncode
Copy link
Contributor

@Kahncode Kahncode commented May 1, 2021

Hello, I have improved the retry system of the generator as per Epic's suggestion. The new Http retry system allows timeouts and exponential backoff (technically unreal's implementation is arithmetic not exponential).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

@Kahncode
Copy link
Contributor Author

Kahncode commented May 1, 2021

Hello, I have not managed to produce updated cpp-ue4 samples using the script. I'd be happy to fix what is needed if someone can guide me.

@wing328
Copy link
Member

wing328 commented May 4, 2021

Updated samples via 47693b8.

@Kahncode
Copy link
Contributor Author

Kahncode commented May 5, 2021

@wing328 it seems like the failed check is about the contributing.md change? anything I should do?

@wing328 wing328 added this to the 5.1.1 milestone May 6, 2021
@wing328
Copy link
Member

wing328 commented May 6, 2021

Don't worry. I'll fix it after merging this PR to the master.

Thanks for the PR as always.

@wing328 wing328 merged commit 343d7eb into OpenAPITools:master May 6, 2021
@wing328
Copy link
Member

wing328 commented May 6, 2021

Pushed 7703c92 with updated doc to the master.

@Kahncode Kahncode deleted the cpp-ue4-retrysystem branch May 24, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants