Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #9192

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #9192

wants to merge 4 commits into from

Conversation

Orachigami
Copy link

@Orachigami Orachigami commented Apr 6, 2021

Fixes: #8255

  • Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
  • Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Alexander added 3 commits April 5, 2021 15:02
…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`.

Added a remote specification project generation test and a WireMock dependency
@Orachigami Orachigami changed the title [Kotlin] Issue #8255 fix (inputSpec param not accepts URL) [Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) Apr 7, 2021
Comment on lines -95 to +93
@get:InputFile
@PathSensitive(PathSensitivity.RELATIVE)
@Optional
@Input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.

Maybe splitting the input specification location into local specs and remote specs would make sense?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Gradle plugin doesn't support remote locations for inputSpec
2 participants