Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bash] Update Bash Client Dockerfile.mustache #8973

Closed
wants to merge 16 commits into from

Conversation

avbenavides
Copy link
Contributor

Using alpine instead of ubuntu for leaner Docker images.

Small fix for welcome message.

Changing default shell to zsh and fixing entrypoint.

@bkryza @frol @bkryza @kenjones-cisco

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@avbenavides avbenavides changed the title Update Bash Client Dockerfile.mustache [bash] Update Bash Client Dockerfile.mustache Mar 15, 2021
@wing328
Copy link
Member

wing328 commented Apr 3, 2021

This PR targets 6.0.x, which has breaking changes without fallbacks.

Can this change target master instead? or can you elaborate on the breaking changes without fallbacks?

@avbenavides avbenavides changed the base branch from 6.0.x to master April 6, 2021 05:57
@avbenavides
Copy link
Contributor Author

@wing328 Targeting master

@wing328
Copy link
Member

wing328 commented Apr 22, 2021

I've filed #9310 instead to address the merge conflicts

@wing328 wing328 closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants