Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previously removed url encode feature to WebClient #8171

Conversation

tivadarbocz
Copy link
Contributor

@tivadarbocz tivadarbocz commented Dec 12, 2020

This previous PR #5255 removed not only the double url encoding, but
all url encoding. So I put back a single url encoding feature.

@bbdouglas, @sreeshas, @jfiala, @lukoyanov, @cbornet, @jeff9finger, @karismann, @Zomzog, @lwlee2608, @bkabrda

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 5.0.0 milestone Dec 18, 2020
@wing328 wing328 merged commit f19f706 into OpenAPITools:master Dec 18, 2020
@zapek
Copy link
Contributor

zapek commented Feb 9, 2021

Well, now it's encoded twice again.
And the reason is (from looking with a debugger), webclient's uri() method encodes too.

@wing328
Copy link
Member

wing328 commented Feb 9, 2021

@zapek can you please file a fix? I'll test your test fix manually to confirm the behaviour this time.

@zapek
Copy link
Contributor

zapek commented Feb 9, 2021

@wing328 #8660

@wing328
Copy link
Member

wing328 commented Mar 16, 2021

Thanks for the fix, which has been merged.

@tivadarbocz please give the latest master a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants