[Typescript][Angular] Fix generated README when using apiModulePrefix #7725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorohan
force-pushed
the
bugfix/typescript-angular-docs-with-module-prefix
branch
2 times, most recently
from
d3349a5
to
06d17ef
Compare
macjohnny
reviewed
Oct 15, 2020
| import { ApiModule } from 'my-api-path'; | ||
| import { ApiModule as OtherApiModule } from 'my-other-api-path'; | ||
| import { {{apiModuleClassName}} } from 'my-api-path'; | ||
| import { OtherApiModule } from 'my-other-api-path'; |
There was a problem hiding this comment.
please keep the alias example with as, see #7722 (comment)
| This is to ensure that all services are treated as singletons. | ||
|
|
||
| #### Using multiple OpenAPI files / APIs / ApiModules | ||
| In order to use multiple `ApiModules` generated from different OpenAPI files, | ||
| you can create an alias name when importing the modules | ||
| in order to avoid naming conflicts: | ||
| you can avoid naming conflicts by configuring `apiModulePrefix` when generating other modules. |
There was a problem hiding this comment.
please reword to include the case when the prefix cannot be set:
#7722 (comment)
There was a problem hiding this comment.
I've just reverted the wording (but changed it to use {{apiModuleClassName}}). I think it's best like this. Now only the sample for with-prefixed-module-name has changed.
|
@sorohan thanks for your contribution |
sorohan
force-pushed
the
bugfix/typescript-angular-docs-with-module-prefix
branch
2 times, most recently
from
2a7b741
to
db16c02
Compare
macjohnny
approved these changes
Oct 15, 2020
|
@sorohan please rebase onto the current master and update the readme for the customized configuration class name |
sorohan
force-pushed
the
bugfix/typescript-angular-docs-with-module-prefix
branch
from
db16c02
to
48e69e5
Compare
|
@macjohnny I've rebased it now. I'm not sure what update to the readme you mean. Can you clarify? |
jimschubert
added a commit
that referenced
this pull request
Oct 17, 2020
* master: (66 commits) [Typescript][Angular] Fix generated README when using apiModulePrefix (#7725) remove outdated scala files (#7723) [FEAT][TYPESCRIPT-ANGULAR] Add configurationPrefix option to allow generating unique configuration token (#7731) [bug] Fix FILES sort and path provider issue (#7729) better csharp tests (#7727) [go] Improve examples generation (#7576) Fixes #7635: typescript-inversify generator wrongly handles array type parameters (#7636) [Java] Fix import mapping for arrays with reference items of type string (#7182) [Java][Native] Support oneOf/anyOf schemas (#7263) [BUG][Ada] Incorrect client Ada code generated (#7719) add cake, sbt integration (#7713) Use 3.0 spec in documentations, update docs (#7710) remove github.com/antihax/optional from go.sum (#7692) Update junit to newer version (4.13.1) (#7690) [Fix/Dart2] Resolve an exception with status 204 and no body. (#7647) [typescript-angular] pass array as a single JSON string to url query when queryParamObjectFormat=json (fix #7620) (#7649) Add back HttpSigningConfiguration.cs remove HTTPSigningConfiguration.cs add AnyType support to Swift generators (#7644) fix warning, remove trailing spaces (#7659) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7722