Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-slim4] Mark generated tests as incomplete #6541

Merged
merged 2 commits into from
Jun 14, 2020

Conversation

ybelenko
Copy link
Contributor

@ybelenko ybelenko commented Jun 4, 2020

I've found markTestIncomplete method in PHPUnit. It perfectly fits our autogeneration flow.
Ref: PHPUnit 7.0 Manual - 7. Incomplete and Skipped Tests

Result of tests:

$ composer test
> phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII.II.II.IIIIIIIIIIII.II.I  63 / 520 ( 12%)
I.II.II.III.IIII.II.II.IIII.II.IIIII.IIIIIII.II.IIII.III.II.II. 126 / 520 ( 24%)
II.IIII.III.I.IIIIII.III.II.IIIIIIIIIIIIIII.III.IIIII.IIII.III. 189 / 520 ( 36%)
II.II.IIIII.II.IIIIIII.IIII.I.IIIIIII.III.II.III.IIIIII.IIIIIII 252 / 520 ( 48%)
.IIIIIIIII.IIIIIIIIIIIIIIIIIIIIIIIIIIIIII...................... 315 / 520 ( 60%)
............................................................... 378 / 520 ( 72%)
............................................................... 441 / 520 ( 84%)
............................................................... 504 / 520 ( 96%)
................                                                520 / 520 (100%)

Time: 2.88 seconds, Memory: 18.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 520, Assertions: 8004, Incomplete: 246.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon

PHPUnit has special "markTestIncomplete" method which is perfectly fits
our generation flow.
Ref: https://phpunit.readthedocs.io/en/7.0/incomplete-and-skipped-tests.html
@ybelenko ybelenko added this to the 5.0.0 milestone Jun 7, 2020
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit c7de5e2 into OpenAPITools:master Jun 14, 2020
@ybelenko ybelenko deleted the slim4_incomplete_tests branch June 14, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants