Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] mark ES5 as deprecated #6408

Merged
merged 12 commits into from
May 26, 2020
Merged

[JS] mark ES5 as deprecated #6408

merged 12 commits into from
May 26, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 23, 2020

  • mark ES5 as deprecated
  • remove samples
  • migrate samples to use oas3

cc @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added the WIP Work in Progress label May 23, 2020
@wing328 wing328 added this to the 5.0.0 milestone May 25, 2020
@wing328 wing328 merged commit d49de5b into master May 26, 2020
@wing328 wing328 deleted the js-es5-deprecated branch May 26, 2020 01:55
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 27, 2020
* master:
  [kotlin][client] add support for coroutines with OkHttp (OpenAPITools#6362)
  update package-json.lock (OpenAPITools#6430)
  fix hardcoded match type (OpenAPITools#6431)
  java jersey2 enhance anyOf (OpenAPITools#6420)
  [Java][jersey2] minor improvement to jersey2 tests (OpenAPITools#6418)
  ps minor style change (OpenAPITools#6424)
  [JS] mark ES5 as deprecated (OpenAPITools#6408)
  [ci] Execute maven and verify with no-snapshot-updates (OpenAPITools#6415)
  add new file in ts axios samples
  Migrate all scala generators to use OAS3 (OpenAPITools#6407)
  migrate ruby samples to oas3 (OpenAPITools#6414)
  [PS] check if JSON properties is defined (OpenAPITools#6419)
  Add C++ UE4  client generator (OpenAPITools#6399)
  Add a link to the article in dev.to (OpenAPITools#6421)
  typescript-axios anytype is not defined (OpenAPITools#6335)
  [Java][jersey2] Make (de)serialization work for oneOf models, add convenience and comparison methods (OpenAPITools#6323)
  Migrate OCaml petstore to use OAS v3 spec (OpenAPITools#6348)
  [Python-experimental] Fix type error if oneof/anyof child schema is null type (OpenAPITools#6387)
  [Python-server] Fix blueplanet 'file not found' error  (OpenAPITools#6411)
  [nodejs] Fix deprecation notice when running sample nodejs script (OpenAPITools#6412)
jimschubert added a commit that referenced this pull request May 27, 2020
* master:
  [kotlin][client] add support for coroutines with OkHttp (#6362)
  update package-json.lock (#6430)
  fix hardcoded match type (#6431)
  java jersey2 enhance anyOf (#6420)
  [Java][jersey2] minor improvement to jersey2 tests (#6418)
  ps minor style change (#6424)
  [JS] mark ES5 as deprecated (#6408)
  [ci] Execute maven and verify with no-snapshot-updates (#6415)
  add new file in ts axios samples
  Migrate all scala generators to use OAS3 (#6407)
  migrate ruby samples to oas3 (#6414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant