Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java-jersey2] Add new ApiClient constructor with auth objects #6393

Merged
merged 13 commits into from
May 22, 2020

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented May 22, 2020

For HTTP signature, the caller needs to be able to pass the HTTP signature parameters as arguments to the ApiClient constructor.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sebastien-rosset
Copy link
Contributor Author

@wing328

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 912604f into OpenAPITools:master May 22, 2020
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 23, 2020
* master:
  [samples] Regenerate python-experimental
  [core][general] Add metadata file tracking to aid in "Golden Tests" regeneration (OpenAPITools#6325)
  [python-experimental] Add support for pep 3134, attach cause of exception (OpenAPITools#6388)
  [Java-jersey2] Add new ApiClient constructor with auth objects (OpenAPITools#6393)
@sebastien-rosset sebastien-rosset deleted the java-apiclient-constructor branch May 23, 2020 19:21
@wing328 wing328 added this to the 5.0.0 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants