-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Refactor templating management #6357
Merged
jimschubert
merged 33 commits into
OpenAPITools:master
from
jimschubert:cleanup-template-management
May 30, 2020
Merged
Changes from 13 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
636c4dd
[core] Refactor templating management
jimschubert d67d3d4
Fix javadoc errs
jimschubert 66f49b6
Tests for dry run file outputs
jimschubert 6a745de
Update API usage in Meta, test TemplateManager
jimschubert a1b23d9
Fix temp file in overwrite test.
jimschubert f3ccf3c
Wait on lastModified, lookup by filename in SpringCodegenTest
jimschubert 4c3c28e
Remove minimal update test from DefaultGenerator (dupe with TemplateM…
jimschubert bb804a4
Test DefaultGenerator + ignore file
jimschubert ecb985e
Move config.processOpenAPI in DefaultGenerator
jimschubert f970e7c
Clarify comment in GeneratorTemplateContentLocator
jimschubert 8062b77
Do not overwrite existing test files
jimschubert 048cc6e
Fix wrong use of libraries templateDirector (java)
jimschubert d5307f3
[samples] Regenerate
jimschubert e267159
Merge branch 'master' into cleanup-template-management
jimschubert edaa592
Fix handlebars extension usage, clean up Meta tasks
jimschubert ccbcf6f
Merge branch 'master' into cleanup-template-management
jimschubert ef4e835
Merge branch 'master' into cleanup-template-management
jimschubert 00ebf20
Merge branch 'master' into cleanup-template-management
jimschubert 5f6368c
Move FILES/VERSION metadata gen to private methods
jimschubert 9b046c2
Update kotlin-multiplatform gradle wrapper
jimschubert 8943146
Rename GraphQL .gitignore template
jimschubert d256cec
Log entire stacktrace in go sdk built by gradle in AppVeyor
jimschubert 33f89fd
Rename PHP .gitignore to gitignore
jimschubert 3ea7469
[samples] Regenerate
jimschubert bc86eea
[php] Rename .gitignore templates to gitignore
jimschubert e934bec
Use same classpath lookup in common locator
jimschubert 062b4d2
Merge branch 'master' into cleanup-template-management
jimschubert 8faa776
[samples] Regenerate
jimschubert e3dcb2f
Merge branch 'master' into cleanup-template-management
jimschubert ff91eec
Regenerate rust samples
jimschubert 9a982d4
[rust] Properly escape empty triple-braces
jimschubert 5166440
Merge branch 'master' into cleanup-template-management
jimschubert 2033a90
[samples] Regenerate
jimschubert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note these removals of
libraries/<library name>
in the Java sample configs and scripts.While this syntax works if the entirety of the library code is in the named folder, this would cause fallbacks to fail if anyone were to remove something like
model.mustache
intending to fallback toresources/Java/model.mustache
. We should avoid this possible confusion especially when these subdirectories are structured to follow our library lookup logic:custom_template/libraries/feign/model.mustache
)custom_template/model.mustache
)resources/Java/libraries/feign/model.mustache
)resources/Java/model.mustache
)resources/_common/model.mustache
)TemplateNotFoundException