[BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf)

[vvalchev]

Fixed issue #6070 - [BUG][All Languages] Multi-Part content type in respons…e ignores properties of composed schema (allOf/oneOf)

#6070

This change uses the existing addProperties() method to combine properties of composed schemas.

Before the change, the generated file looked like:
https://gist.github.com/vvalchev/54a935c0f93c06a184a9eeb1640f96e6#file-usersapi-java

After the change, the fist method is properly generated and includes all inherited properties:
https://gist.github.com/vvalchev/54a935c0f93c06a184a9eeb1640f96e6#file-usersapi-java-fixed

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

fixes #6070

[wing328]

cc @OpenAPITools/generator-core-team

[vvalchev]

3 months, 2 days passed

[jimschubert]

@vvalchev thanks for bumping this, and thanks for providing the level of detail for repro and the fix.

Your PR was likely not picked up quickly because of the original title ("Fixed issue #6070"), and because your changes were to DefaultCodegen but tagged the Java technical committee.

I can't speak for others, only for myself, but I'm much quicker to pick up pull requests with clear titles and/or labels because nondescript titles often don't contain the level of details you've provided in the PR description. I'll propose a change to our contributing documentation and issues/pull templates to clarify the importance of the titles and repro steps.

I pulled this and merged master up to the branch, then tested this locally with the following config file:

generatorName: jaxrs-spec
apiPackage: com.mycompany.api
modelPackage: com.mycompany.dto
additionalProperties:
  dateLibrary: java8
  java8: 'true'
  useBeanValidation: 'true'
  performBeanValidation: 'true'
  useTags: 'true'
  interfaceOnly: 'true'
  skipDefaultInterface: 'true'

And CLI args:

generate -g jaxrs-spec -i .bak/6073/spec.yaml -c .bak/6073/config.yaml -o .bak/6073/out

Everything looks good. Thanks for the excellent contribution!