Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codegen][Python-experimental] Discriminator NPE fix, handle 'null' type, #4906 enhancements #5809
[codegen][Python-experimental] Discriminator NPE fix, handle 'null' type, #4906 enhancements #5809
Changes from all commits
3f889df
e5e4bfd
8d8a749
7cc1329
662eaff
5044db9
dcd4540
de8e694
6a0d479
778d250
ff6f1ff
4d4910a
78e171a
a089a45
9461ab4
035436f
75ff63c
41de5b5
8fb94f2
f31712b
bf53e4f
dc39548
af27e33
80745cf
9534289
7f73adf
34c4c09
c7f1bce
2b389fa
90593ce
fe1669a
6492b76
bf0e3a3
86d1fc3
1208da8
b65aca8
250cd14
ba21728
7a98f6e
c505639
dd0113a
8b427fe
d187295
721a720
01f7e5b
1d62e7b
29bc8e6
ca0fa6e
7aa07b5
a7a5cca
cb6c4bd
53ba1fa
23c5c38
e3b6522
7b85b2d
53ab46b
7242b94
ddefbea
831c99a
6ab57c8
607f638
bc23d3e
052bccc
89c8025
936c0b1
9e7a0ca
79ec2d5
6c571f0
7b8269c
f106c67
79bbab8
55b6ff4
46669f1
4a40e33
037b7ee
cc0bb25
9bf9f3d
7a37221
4132d45
9a596c7
e7c4396
fe2b2da
0fdd7e3
9849c83
bca2110
9329705
b1329d2
1fd8ba3
ca44756
f80ca49
a16d507
2254a96
3c8aeea
07cfeb0
f68941d
cc7f0d5
ab11452
360b1a1
d561bcd
71c5a8d
6b2c41f
d634f05
43e94ed
b587d59
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not yet handling the use case where discr_name is not in model_class.discriminator here.
If we hit that case, then the discriminator propertyName is different than what we are looking for and we should return None early. Here, can you add:
Or maybe we should make it the clearer: