Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-angular: fix handling of date object in query parameter #5225

Merged

Conversation

mcpummec
Copy link
Contributor

@mcpummec mcpummec commented Feb 6, 2020

fixes #5223

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny
Copy link
Member

cc @aanno2

@macjohnny macjohnny changed the title pass key to http params for date objects typescript-angular: pass key to http params for date objects Feb 6, 2020
@macjohnny
Copy link
Member

cc @akehir @amakhrov

@macjohnny macjohnny added this to the 4.3.0 milestone Feb 6, 2020
@macjohnny macjohnny changed the title typescript-angular: pass key to http params for date objects typescript-angular: fix handling of date object in query parameter Feb 6, 2020
@macjohnny macjohnny merged commit 8779fc6 into OpenAPITools:master Feb 6, 2020
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
@wing328
Copy link
Member

wing328 commented Mar 27, 2020

@mcpummec thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typescript-angular] Bug generating APIs with Date-Time parameters
3 participants