Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] Explicitly set netCoreProjectFile only for .NET Core target #5151

Merged
merged 2 commits into from
Feb 1, 2020
Merged

[csharp-netcore] Explicitly set netCoreProjectFile only for .NET Core target #5151

merged 2 commits into from
Feb 1, 2020

Conversation

shibayan
Copy link
Contributor

@shibayan shibayan commented Jan 29, 2020

PR detail

  • Use always useNetCoreProject = true for .NET Core
  • Respect useNetCoreProject setting for .NET Standard
  • Default value is false, so if not specified, the behavior is the same as before

This PR fixes #3691

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@mandrean @jimschubert @frankyjuang

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 8197a8a into OpenAPITools:master Feb 1, 2020
@wing328 wing328 added this to the 4.3.0 milestone Feb 1, 2020
@shibayan shibayan deleted the netcore-project branch February 1, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][csharp-netcore] Setting netCoreProjectFile doesn't work
2 participants